In my experience, the ideal time to start discussing study skills is in Year 9 or 10 of secondary school.
At this stage of education, students are starting to think about GCSEs but still have plenty of time to experiment with new techniques and shift habits.
Students in Years 11-13 also benefit from study skills coaching as preparation for GCSEs, A Levels and further study.